Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#1052 closed Feature Request (fixed)

Add LV2_UI__resize for plugin resizing

Reported by: ssj71 Owned by: dave
Priority: minor Component: Jalv
Keywords: Cc:

Description

currently the infamous plugins GUIs only resize properly in carla. I'm preparing to release the guis soon, but thought I'd at least request this first. If you have interest in adding this feature, it would be nice for my plugs to have tolerably consistent behavior between hosts. If you'd like to test using the infamous plugins (probably the only ones with this problem) then use the gui branch of my repo: git://git.code.sf.net/p/infamousplugins/code
Thanks!

Change History (6)

comment:1 Changed 2 years ago by ssj71

  • Summary changed from [feature] Add LV2_UI__resize for plugin resizing to Add LV2_UI__resize for plugin resizing
  • Type changed from Bug Report to Feature Request

comment:2 Changed 22 months ago by ssj71

  • Resolution set to fixed
  • Status changed from new to closed

found that this is handled correctly already if all fltk widgets are in a group and the XID of the window is returned as the *LV2_UI_Widget. So another rtfm error on my part. Apologies.

comment:3 Changed 22 months ago by falkTX

We should add a comment about it somewhere.
It's not directly clear that host-side resize feature is simply available if you return the X11 Window ID.
AFAIK other platforms do not have this (at least win32).

comment:4 Changed 22 months ago by dave

I don't really get it. For an X11UI, returning the X11 window ID isn't an option. That's what an X11UI is, by definition. The only reason returning junk for this doesn't catastrophically explode is that X11 uses integer IDs (not pointers) and tolerates nonsense IDs.

I suppose Suil could add a check that the returned thing is actually a valid Window and complain loudly if that is not the case.

Yes, this feature is implemented in the wrapper by Suil.

comment:5 Changed 22 months ago by ssj71

Are any UI types not resized correctly? Perhaps resize as extension should be deprecated and it only be used for UI->host?

comment:6 Changed 22 months ago by dave

I have never been a fan of the extension. All window APIs obviously have mechanism to resize windows, so having another API grafted on to do it is a kludge at best.

I only added it because nobody could / bothered to get it working properly at the time.

Note: See TracTickets for help on using tickets.