Opened 7 months ago

Closed 7 months ago

#1168 closed Bug Report (fixed)

Suil leaks memory in x11_in_gtk2 and x11_in_gtk3

Reported by: jpcima Owned by: David Robillard
Priority: trivial Component: Suil
Keywords: Cc:

Description

According to XQueryTree(3), the list of children should be freed using XFree() when it is non-NULL. This error exists in 2 occurences: x11_in_gtk2.c and x11_in_gtk3.c

Change History (3)

comment:1 Changed 7 months ago by David Robillard

Resolution: fixed
Status: newclosed

Fixed, thanks.

comment:2 Changed 7 months ago by jpcima

Resolution: fixed
Status: closedreopened

I'm afraid the fix applied is only a half-fix. :) The early return path doesn't free.

comment:3 Changed 7 months ago by David Robillard

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.