Opened 5 months ago

Closed 5 months ago

#1168 closed Bug Report (fixed)

Suil leaks memory in x11_in_gtk2 and x11_in_gtk3

Reported by: jpcima Owned by: dave
Priority: trivial Component: Suil
Keywords: Cc:

Description

According to XQueryTree(3), the list of children should be freed using XFree() when it is non-NULL.
This error exists in 2 occurences: x11_in_gtk2.c and x11_in_gtk3.c

Change History (3)

comment:1 Changed 5 months ago by dave

  • Resolution set to fixed
  • Status changed from new to closed

Fixed, thanks.

comment:2 Changed 5 months ago by jpcima

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm afraid the fix applied is only a half-fix. :)
The early return path doesn't free.

comment:3 Changed 5 months ago by dave

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.