Opened 10 years ago

Closed 10 years ago

#651 closed Bug Report (fixed)

MIDI events from LV2 GUIs do not work correctly (patch attached)

Reported by: mail@… Owned by: David Robillard
Priority: major Component: Ingen
Keywords: Cc:

Description

Ingen has two problems with sending MIDI events from an LV2 GUI (e.g. Klaviatur).

  1. The event types aren't mapped correctly. Ingen uses two different URI-to-ID mappings internally, one global and one just for events. The events are mapped according to the global map, so the plugin does not recognise the event types.
  1. If no other MIDI port is connected to the plugin port that receives the events, the port buffer will not get cleared and the MIDI events sent from the GUI will stay in the buffer and be repeated in every subsequent run() period.

The attached patch fixes both problems. I am not sure how this interacts with the Atom stuff though.

Attachments (1)

ui_midi_fixes.diff (3.6 KB) - added by mail@… 10 years ago.

Download all attachments as: .zip

Change History (2)

Changed 10 years ago by mail@…

Attachment: ui_midi_fixes.diff added

comment:1 Changed 10 years ago by David Robillard

Resolution: fixed
Status: newclosed

Looks good, thanks. Applies to Atoms exactly as it applies to MIDI events.

Applied in r3048.

Note: See TracTickets for help on using tickets.