Opened 6 years ago

Closed 6 years ago

#1013 closed Bug Report (fixed)

Edge selections remain active after clicking a blank part of the Canvas to remove selection (updated: proposed patch)

Reported by: anonymous Owned by: David Robillard
Priority: major Component: Ganv
Keywords: Cc:

Description

Edge selection remains active after clicking in a blank part of the Canvas even though the 'marching ants' disappear. I discovered this while trying to work around the edge selection signal not firing and then firing too often after I tried to patch the issue.

I've created a minimal test program the source-code of which I've attached. That'll make the issue a bit easier to describe and you'll be able to see if it's a genuine bug. You might have to edit the makefile as I have ganv installed in a non-standard location.

The test program's single toolbar button, when clicked, displays the number of selected edges. If you select the edges by drawing boxes around them then click a blank part of the canvas the "marching ants" will disappear. But if you click the button in the left, it will report that a number of edges are still selected. Drawing a box around everything (including the modules) then clicking in a blank area will usually return the selected edge count to zero.

Attachments (2)

edgecount.tar (10.0 KB) - added by anonymous 6 years ago.
canvas_cpp_changes_2.patch (577 bytes) - added by anonymous 6 years ago.
patch to canvas.cpp (also contains patch for issue #1010)

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by anonymous

Attachment: edgecount.tar added

comment:1 Changed 6 years ago by anonymous

Component: BLOPOther
Summary: Edge selections remain active clicking in a blank part of the Canvas to remove selectionGanv 1.4.2: Edge selections remain active clicking in a blank part of the Canvas to remove selection

comment:2 Changed 6 years ago by anonymous

Summary: Ganv 1.4.2: Edge selections remain active clicking in a blank part of the Canvas to remove selectionGanv 1.4.2: Edge selections remain active after clicking a blank part of the Canvas to remove selection

comment:3 Changed 6 years ago by anonymous

I've attached a patch which fixed the issue for me.

Changed 6 years ago by anonymous

Attachment: canvas_cpp_changes_2.patch added

patch to canvas.cpp (also contains patch for issue #1010)

comment:4 Changed 6 years ago by anonymous

Summary: Ganv 1.4.2: Edge selections remain active after clicking a blank part of the Canvas to remove selectionGanv 1.4.2: Edge selections remain active after clicking a blank part of the Canvas to remove selection (updated: proposed patch)

comment:5 Changed 6 years ago by David Robillard

Patch is not correct, issue was the list is not cleared when the selection is cleared.

Fixed in r5610, thanks.

P.S. Please avoid changing ticket titles unnecessarily to keep the noise down

comment:6 Changed 6 years ago by David Robillard

Component: OtherGanv
Resolution: fixed
Status: newclosed
Summary: Ganv 1.4.2: Edge selections remain active after clicking a blank part of the Canvas to remove selection (updated: proposed patch)Edge selections remain active after clicking a blank part of the Canvas to remove selection (updated: proposed patch)
Note: See TracTickets for help on using tickets.