Opened 6 years ago

Closed 5 years ago

#1091 closed Bug Report (wontfix)

Revert graceful failure to open wrapper [patch]

Reported by: Rui Nuno Capela Owned by: David Robillard
Priority: major Component: Suil
Keywords: Cc:

Description

  • Revert graceful failure to open wrapper [patch] (REGRESSION)

partially reverts svn r5724 by drobilla on 2015-09-12, as found needed to maintain backward compatibility (to 0.8.2) as much for non-wrappable UI types (eg. external UI, http://lv2plug.in/ns/extensions/ui#external) and still supported or in use by some hosts (eg. qtractor).

Attachments (1)

suil-0.8.3svn5732-instance-R1.patch (884 bytes) - added by Rui Nuno Capela 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Rui Nuno Capela

comment:1 Changed 6 years ago by David Robillard

Trouble with this is errors are indistinguishable from a missing wrapper. How does the host know that it didn't actually get the container type it requested? Accidentally doing so would be a fatal error.

Note you can pass a NULL container_type_uri to get the UI without any wrapping. This seems like what a host using Suil in a non-wrap case should do to me.

comment:2 Changed 6 years ago by Rui Nuno Capela

as said this patch is about to maintain backward compatibility to suil <= 0.8.2 and eg. qtractor <= 0.7.0;

as far as i'm concerned, this patch is perfectly optional and may be just closed and/or graciously ignored :)

comment:3 Changed 5 years ago by David Robillard

Resolution: wontfix
Status: newclosed

Okay, closing. Reverting this fix seems more problematic than not, and if the only reason is compatibility between a new library and old host, well, whatever.

Note: See TracTickets for help on using tickets.