Opened 13 years ago

Closed 13 years ago

#235 closed Bug Report (fixed)

another crash when changing polyphony

Reported by: kfoltman Owned by:
Priority: major Component: Ingen
Keywords: Cc:

Description

I can't really pinpoint this one, it might be due to a plugin bug, but comparing the complexity of Ingen polyphony and timer plugin makes Ingen a likely suspect ;)

Try loading the attached patch and playing with it with polyphony set to 2 or more. Sometimes it works just fine, sometimes the "envelope" (timer-based decay-only) gets stuck in some random buzzy place.

Attachments (1)

4osc.ingen.ttl (14.0 KB) - added by kfoltman 13 years ago.
A couple of detuned saw passed through 24dB/oct lowpass... classic and boring

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by kfoltman

Attachment: 4osc.ingen.ttl added

A couple of detuned saw passed through 24dB/oct lowpass... classic and boring

comment:1 Changed 13 years ago by kfoltman

Summary: weird control port behaviour with polyphony > 1another crash when changing polyphony

r1670 crashes during polyphony increase.

comment:2 Changed 13 years ago by kfoltman

Looks like crash occurs when any plugin is connected to patch output port (audio output, control output etc).

The diff below fixes the crash, but doesn't fix the weird behaviour with multiple voices.

Index: src/engine/PatchImpl.cpp
===================================================================
--- src/engine/PatchImpl.cpp	(revision 1675)
+++ src/engine/PatchImpl.cpp	(working copy)
@@ -123,6 +123,9 @@
 	for (List<NodeImpl*>::iterator i = _nodes.begin(); i != _nodes.end(); ++i)
 		(*i)->apply_poly(maid, poly);
 
+	for (Connections::iterator i = _connections.begin(); i != _connections.end(); ++i)
+		((ConnectionImpl*)i->get())->apply_poly(maid, poly);
+
 	_internal_poly = poly;
 
 	return true;

comment:3 Changed 13 years ago by David Robillard

Resolution: fixed
Status: newclosed

Seems fixed now. Reopen if not.

Note: See TracTickets for help on using tickets.